Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Not analyzed data color #130

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

ahmedfarouk2000
Copy link
Collaborator

Consistant color for regions with no data, and update legends with not analyzed data point.

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for wfp-hungermap ready!

Name Link
🔨 Latest commit d78d54a
🔍 Latest deploy log https://app.netlify.com/sites/wfp-hungermap/deploys/6761fc5643583e0008bc644d
😎 Deploy Preview https://deploy-preview-130--wfp-hungermap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -2,6 +2,10 @@
@tailwind components;
@tailwind utilities;

:root {
--nextui-notAnalyzed: 0, 0%, 55%;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this if it is already defined in tailwind config?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the color was kinda transparent, but anyways I have applied another color and removed this part.

Copy link
Collaborator

@bohdangarchu bohdangarchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@marinovl7 marinovl7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, however this is somehow not working for the IPC Country View. Can you have a look?

image

@ahmedfarouk2000
Copy link
Collaborator Author

Great job, however this is somehow not working for the IPC Country View. Can you have a look?

image

done

@marinovl7 marinovl7 merged commit 41764ad into main Dec 18, 2024
5 checks passed
@marinovl7 marinovl7 deleted the feature/f-153-Not-Analyzed-Color branch December 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants