Feature/f 64 charts option improvements #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to LineChartOperations
…y to LineChartOperations
…s with JSX code any more
✅ Deploy Preview for wfp-hungermap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bohdangarchu
requested changes
Nov 18, 2024
marinovl7
requested changes
Nov 18, 2024
bohdangarchu
approved these changes
Nov 18, 2024
…uplicate code in LineChartModal and LineChart and additional minor syntax improvements
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal was to implement:
https://linear.app/world-food-programme-wfp/issue/F-64/charts-option-improvements
In addition, all the requested changes from the last pull request have been implemented: #21
Except for the task to “chart modal to own component” -> I still have a question before making the changes: Wouldn't it make more sense to keep the modal inside since the regular LineChart box component and the modal share many dependencies (e.g. all the state manipulations)?"
And... I have a quick question: as requested, I moved all 'const button = <...>' components directly into the return statement. Is it generally intended for the future that JSX code should only appear within the return statement?