Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/f 60 implement data sources page #44

Merged
merged 19 commits into from
Nov 19, 2024
Merged

Feature/f 60 implement data sources page #44

merged 19 commits into from
Nov 19, 2024

Conversation

jschoedl
Copy link
Collaborator

  • Go to /data_sources to test.
  • The info icons are still using the white SVG until @ArmanpreetGhotra deals with that.
  • I will make the table modifications more generic to be able to merge with @ahmedfarouk2000's progress after this PR.

jschoedl added 17 commits November 5, 2024 20:42
@jschoedl
feat: add About page with intro text
bb0f115
@jschoedl
feat: implement grouped table
585612e
@jschoedl
Merge branch 'refs/heads/main' into feature/f-38-implement-glossary-a…
2cd543f 
…nd-methodology-pages
@jschoedl
fix: remove unused icon
14147f9
@jschoedl
fix: use clsx instead of ternary operator
bdda653
@jschoedl
Merge branch 'main' into feature/f-38-implement-glossary-and-methodol…
cbe83b0 
…ogy-pages

# Conflicts:
#	src/styles/globals.css
#	yarn.lock
@jschoedl
fix: extract grouped table logic to groupedTableOperations.tsx
1603456
@jschoedl
feat: add /about page
0001c7a
@jschoedl
feat: add contents to /about page
95f112b
@jschoedl
feat: replace ExternalLink with a more generic StyledLink
c3e5f50
@jschoedl
fix: rename .about-page to .text-content
f5e51b8
@jschoedl
feat: add Data Sources page
975e7aa
@jschoedl
Merge branch 'refs/heads/main' into feature/f-60-implement-data-sourc…
8e34510 
…es-page

# Conflicts:
#	src/app/about/page.tsx
#	src/components/About/AboutText.tsx
#	src/domain/constant/about/accuracyTableContents.tsx
#	src/domain/constant/about/generalFaqItems.tsx
#	src/domain/constant/about/predictionFaqItems.tsx
#	src/domain/props/GroupedTableProps.ts
#	src/styles/globals.css
#	yarn.lock
@jschoedl
feat: add links and layout for /data_sources
4f8340a
@jschoedl
feat: add Abbreviation component
62e5bfd
@jschoedl
Merge branch 'main' into feature/f-60-implement-data-sources-page
5f2c234
@jschoedl
feat: improve /data_sources for mobile
d6ce92b
@jschoedl jschoedl self-assigned this Nov 19, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for wfp-hungermap ready!

Name Link
🔨 Latest commit b4fb02b
🔍 Latest deploy log https://app.netlify.com/sites/wfp-hungermap/deploys/673cf9edab95d80008e9cc05
😎 Deploy Preview https://deploy-preview-44--wfp-hungermap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

marinovl7
marinovl7 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@marinovl7 marinovl7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job Jakob! Also great job with making the data look better, I think this is a major improvement

@marinovl7 marinovl7 merged commit 98032e4 into main Nov 19, 2024
5 checks passed
@marinovl7 marinovl7 deleted the feature/f-60-implement-data-sources-page branch November 19, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinovl7 marinovl7 marinovl7 approved these changes

@bohdangarchu bohdangarchu Awaiting requested review from bohdangarchu

Assignees

@jschoedl jschoedl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschoedl @marinovl7