feat: skeleton of map while loading #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Lukas0912
commented
Nov 19, 2024
Lukas0912
commented
- I added a MapSkeleton based on SVG data in the colors of the map
- also I moved the other Map data and the data for the skeleton in a common folder in the constant area
- the loading skeleton can also be seen on the elements demo page
✅ Deploy Preview for wfp-hungermap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
that is super cool, love it! |
marinovl7
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Great solution! I think something better could not be done, didn't even think about that either, great jib @Lukas0912
marinovl7
deleted the
feature/f-71-skeleton-for-the-map-when-its-loading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.