-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jstzd: add rollup build script and spawn rollup in jstzd #670
Open
ryutamago
wants to merge
3
commits into
main
Choose a base branch
from
leounoki-jstz-164/spawn-rollup-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
from
November 17, 2024 19:08
9092c37
to
24607d3
Compare
ryutamago
commented
Nov 18, 2024
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
from
November 21, 2024 10:53
24607d3
to
0418f5f
Compare
ryutamago
changed the title
[WIP] build rollup preimages and spawn rollup
Jstzd: add build.rs fro the rollup and spawn rollup in jstzd
Nov 21, 2024
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
from
November 21, 2024 11:24
0418f5f
to
a88546d
Compare
zcabter
reviewed
Nov 21, 2024
zcabter
reviewed
Nov 21, 2024
zcabter
reviewed
Nov 21, 2024
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
from
November 21, 2024 11:56
45250c5
to
ffc7da6
Compare
zcabter
reviewed
Nov 21, 2024
zcabter
reviewed
Nov 21, 2024
zcabter
reviewed
Nov 21, 2024
zcabter
reviewed
Nov 21, 2024
zcabter
reviewed
Nov 21, 2024
zcabter
reviewed
Nov 21, 2024
zcabter
reviewed
Nov 21, 2024
zcabter
reviewed
Nov 21, 2024
|
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
from
November 21, 2024 15:13
ffc7da6
to
3b81952
Compare
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
from
November 22, 2024 13:14
a56cbbf
to
8165914
Compare
zcabter
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
from
November 22, 2024 14:20
8165914
to
f6656f0
Compare
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
4 times, most recently
from
November 25, 2024 11:59
98ac9dd
to
7a37ece
Compare
ryutamago
changed the title
Jstzd: add build.rs fro the rollup and spawn rollup in jstzd
Jstzd: add rollup build script and spawn rollup in jstzd
Nov 25, 2024
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
2 times, most recently
from
November 29, 2024 13:32
0dc68a8
to
3933223
Compare
zcabter
reviewed
Dec 3, 2024
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
from
December 3, 2024 14:59
b55c674
to
9cf370b
Compare
zcabter
reviewed
Dec 3, 2024
zcabter
reviewed
Dec 3, 2024
zcabter
reviewed
Dec 3, 2024
zcabter
reviewed
Dec 3, 2024
zcabter
reviewed
Dec 3, 2024
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
from
December 3, 2024 15:30
a5e292c
to
1259764
Compare
zcabter
reviewed
Dec 3, 2024
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
from
December 3, 2024 15:48
1259764
to
be30fda
Compare
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-3
branch
from
December 3, 2024 17:17
7e1bb8d
to
8e7f0c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
spawn rollup in jstzd
NOTE:
The jstz kernel rollup seems to not process the block in the CI (i suppose some issue with
nix.flake
)the test works fine with the default nix settings
nix flake check
.I also replaced the jstz kernel with the toy rollup kernel and that worked with the
nix.flake
Description
There are two parts in this PR:
a. Modified the MakeFile so that the kernel.wasm is copied to crates/jstzd/
b. Add build.rs that 1) stores the rollup kernel_installer.hex, preimages/ and parameters_ty.json to OUT_DIR. 2) generate a path getter file (jstz_rollup_path.rs) to access the path of 1
Manually testing the PR
added rollup to the jstzd integration test.