-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new account #762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryutamago
force-pushed
the
leounoki-jstz-255/migrate-to-new-account2
branch
from
January 13, 2025 13:30
ed56fa8
to
bcae52d
Compare
ryutamago
force-pushed
the
leounoki-jstz-257/introduce-new-account-type
branch
from
January 13, 2025 21:34
ab024ef
to
5aef9b2
Compare
ryutamago
force-pushed
the
leounoki-jstz-255/migrate-to-new-account2
branch
from
January 13, 2025 21:35
bcae52d
to
3f1ed55
Compare
ryutamago
force-pushed
the
leounoki-jstz-257/introduce-new-account-type
branch
2 times, most recently
from
January 13, 2025 22:19
0a2db5c
to
e8957be
Compare
ryutamago
force-pushed
the
leounoki-jstz-255/migrate-to-new-account2
branch
2 times, most recently
from
January 13, 2025 22:26
d6372e8
to
89b0512
Compare
ryutamago
changed the title
Leounoki jstz 255/migrate to new account2
Migrate to new account
Jan 14, 2025
ryutamago
force-pushed
the
leounoki-jstz-255/migrate-to-new-account2
branch
from
January 14, 2025 12:29
89b0512
to
5ec3046
Compare
ryutamago
force-pushed
the
leounoki-jstz-257/introduce-new-account-type
branch
from
January 14, 2025 16:36
e8957be
to
f1945d2
Compare
ryutamago
force-pushed
the
leounoki-jstz-257/introduce-new-account-type
branch
2 times, most recently
from
January 15, 2025 14:47
40e4cf7
to
a1ac76e
Compare
ryutamago
force-pushed
the
leounoki-jstz-255/migrate-to-new-account2
branch
3 times, most recently
from
January 15, 2025 15:22
66b9b90
to
4d86cd0
Compare
ryutamago
force-pushed
the
leounoki-jstz-257/introduce-new-account-type
branch
from
January 16, 2025 16:16
a1ac76e
to
64d7802
Compare
ryutamago
force-pushed
the
leounoki-jstz-255/migrate-to-new-account2
branch
from
January 16, 2025 16:17
4d86cd0
to
62809b4
Compare
ryutamago
force-pushed
the
leounoki-jstz-257/introduce-new-account-type
branch
from
January 17, 2025 11:08
64d7802
to
513e63a
Compare
Base automatically changed from
leounoki-jstz-257/introduce-new-account-type
to
main
January 17, 2025 11:41
ryutamago
force-pushed
the
leounoki-jstz-255/migrate-to-new-account2
branch
from
January 17, 2025 15:32
62809b4
to
2d00f24
Compare
ryutamago
changed the base branch from
main
to
leounoki-jstz-285/fix-kv-value
January 17, 2025 15:32
ryutamago
force-pushed
the
leounoki-jstz-255/migrate-to-new-account2
branch
2 times, most recently
from
January 18, 2025 21:06
c272d1a
to
3196d27
Compare
huancheng-trili
approved these changes
Jan 20, 2025
Thanks for the manual tests btw. They are great as a starting point for integration tests. |
ryutamago
force-pushed
the
leounoki-jstz-255/migrate-to-new-account2
branch
from
January 20, 2025 10:24
3196d27
to
5b69707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR completes the migration to the new account type.
255
In the next step,
NewAddress
enums are replaced withSmartFunctionHash
for parts that should only use sf(e.g. set_code, the self address of ledger, sf runtime api etc)Description
Replaced the old Account with the new Account. the KT1 address is now supported.
Manually testing the PR
Added unit tests for smart function deployment.
Added unit tests for rejecting non KT1 address for adding sf alias
manually tested sf deployment and running.