feat(agents-api): Allow single instructions str for agents #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Singh Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 7e7ed4b
- Looked at
171lines of code in7files - Took 1 minute and 7 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. sdks/python/tests/fixtures.py:21:
- Assessed confidence :
66% - Grade:
0% - Comment:
Consider maintaining the original list format forinstructionsinmock_agentand creating a separate test case or mock object for testing the single string input scenario. This ensures that both formats are properly tested and supported. - Reasoning:
The PR introduces the ability to accept a single string for agent instructions in the API and SDKs, which is then converted to a list. This is a useful feature for simplifying the API usage when only one instruction is needed. However, the implementation in the Python SDK test (sdks/python/tests/fixtures.py) directly modifies themock_agentdictionary to use a string for instructions, which might not reflect all use cases, especially those expecting a list. This could potentially lead to issues in tests that rely on the original list format of instructions.
Workflow ID: wflow_AnlqrwYuvggVJPRr
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR allows single instruction strings for agents by updating the relevant functions in the
agents-apiand the Python and TypeScript SDKs, and also updates the corresponding tests.Key points:
create_agent,update_agent, andpatch_agentinagents_api/routers/agents/routers.pyto convert single instruction string into a listinstructionsfield inmock_agentintests/fixtures.pyfrom a list to a stringinstructionsfield increatefunction insrc/managers/agent.tsto accept either a string or a list of stringsGenerated with ❤️ by ellipsis.dev