Don't sort keys by default in tojson when rendering profile forms #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinja2's tojson sorts keys in dicts by default. This was useful in the time when python's dicts were not ordered. However, now that dicts are ordered in python, this screws it up. Since profiles are dicts, ordering *does* matter - they should be displayed to the user in the order that the admin sets them. This allows template writers to use `|tojson` on the profile_list (to be read by JS) without worrying about ordering getting mangled. Template writers can still sort keys by explicitly using `|dictsort` in their template
yuvipanda
force-pushed
the
json-no-mangle
branch
from
07d4692 to
46d561d
Compare
yuvipanda
added a commit
to yuvipanda/pilot-hubs
that referenced
this pull request
Sep 19, 2023
consideRatio
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jinja2's tojson sorts keys in dicts by default. This was useful in the time when python's dicts were not ordered. However, now that dicts are ordered in python, this screws it up. Since profiles are dicts, ordering does matter - they should be displayed to the user in the order that the admin sets them. This allows template writers to use
|tojsonon the profile_list (to be read by JS) without worrying about ordering getting mangled. Template writers can still sort keys by explicitly using|dictsortin their template