Fix issue with coredns node hosts controller

[brandond]

Proposed Changes

Fix issue with coredns node hosts controller

The nodes controller was reading from the configmaps cache, but doesn't add any handlers, so if no other controller (the helm controller, for example) adds configmap handlers, the cache would remain empty.

We made the embedded helm-controller disableable a while back, but didn't test the secondary effects that disabling might have on other components that are relying on the caches being populated by the configmap and secret caches that the helm controller fills.

Types of Changes

bugfix

Verification

see linked issue

Testing

Linked Issues

• Core DNS missing NodeHosts key in Configmap #9274

User-Facing Change

fixed issue that could cause coredns pods to fail to start when the embedded helm controller is disabled, due to the configmap not being updated with node hosts entries.

Further Comments

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (57482a1) 45.69% compared to head (3d76699) 14.88%.

Files	Patch %	Lines
pkg/node/controller.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #9354       +/-   ##
===========================================
- Coverage   45.69%   14.88%   -30.81%     
===========================================
  Files         154      154               
  Lines       16623    16625        +2     
===========================================
- Hits         7596     2475     -5121     
- Misses       7814    13833     +6019     
+ Partials     1213      317      -896     

Flag	Coverage Δ
e2etests	?
inttests	5.45% <0.00%> (-32.12%)	⬇️
unittests	15.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.