refactor(storagenode): committer to remove requireCommitWaitTasks parameter #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## remove_deferred_write_batch_code #969 +/- ##
====================================================================
+ Coverage 80.00% 80.19% +0.18%
====================================================================
Files 178 178
Lines 21505 21500 -5
====================================================================
+ Hits 17206 17241 +35
+ Misses 3506 3477 -29
+ Partials 793 782 -11 ☔ View full report in Codecov by Sentry. |
…ameter This PR removes the requireCommitWaitTasks parameter from the commitInternal method. The parameter was used to support sync replication, which is the recovery between two replicas in a log stream. However, sync replication doesn't use commitInternal anymore.
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
bbcb5b1 to
3e1d1de
Compare
ijsong
force-pushed
the
refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
branch
from
75d32d4 to
b74daea
Compare
hungryjang
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR removes the requireCommitWaitTasks parameter from the commitInternal
method. The parameter was used to support sync replication, which is the
recovery between two replicas in a log stream. However, sync replication doesn't
use commitInternal anymore.