Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storagenode): committer to remove requireCommitWaitTasks parameter #969

Open
wants to merge 1 commit into
base: remove_deferred_write_batch_code
Choose a base branch
from

refactor(storagenode): committer to remove requireCommitWaitTasks par…

b74daea
Select commit
Loading
Failed to load commit list.
Open

refactor(storagenode): committer to remove requireCommitWaitTasks parameter #969

refactor(storagenode): committer to remove requireCommitWaitTasks par…
b74daea
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 23, 2025 in 1s

80.19% (+0.18%) compared to 3e1d1de

View this Pull Request on Codecov

80.19% (+0.18%) compared to 3e1d1de

Details

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.19%. Comparing base (3e1d1de) to head (b74daea).

Files with missing lines Patch % Lines
internal/storagenode/logstream/committer.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           remove_deferred_write_batch_code     #969      +/-   ##
====================================================================
+ Coverage                             80.00%   80.19%   +0.18%     
====================================================================
  Files                                   178      178              
  Lines                                 21505    21500       -5     
====================================================================
+ Hits                                  17206    17241      +35     
+ Misses                                 3506     3477      -29     
+ Partials                                793      782      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.