Fix eager loading a Rails app with performs in an associated object

[natematykiewicz]

ActiveJob::Performs was being included in an after_initialize hook, which was after the models were loaded, which means that an associated object that has a performs call in it had no performs method.

This triggered the method_missing to run and find the performs method on the ActiveRecord model, use that, and then attempt to call my associated object name on the return value.

Given this code:

class AudioTrack::ListeningPlanDaySyncer < ActiveRecord::AssociatedObject
  performs :sync
end

performs didn't exist, so it'd call AudioTrack.performs :sync, which returns :sync_later. Then the method_missing code would attempt to run :sync_later.listening_plan_day_syncer and error.

By moving this on_load hook out of after_initialize, I now have a performs method when eager loading.

I think the only reason it was working before is because the models were being lazy loaded, so I didn't attempt to call performs until long after boot.

Note: I'm unsure how to test this. The problem only occurs when eager loading.

[kaspth]

Bah, sorry about that. I figured it would be alright to keep this in an after_initialize.

Note: I'm unsure how to test this. The problem only occurs when eager loading.

Yeah, I'm not sure either.

[natematykiewicz]

No worries at all! Can you ship a version bump?

[kaspth]

You got it! https://github.com/kaspth/active_record-associated_object/releases/tag/v0.5.2

[natematykiewicz]

Thanks Kasper!