fix: faq page filter #218
fix: faq page filter #218
Conversation
|
✔️ Deploy Preview for wargabantuwarga ready! 🔨 Explore the source changes: 738c110 🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/60f6be59546a890007bd338c 😎 Browse the preview: https://deploy-preview-218--wargabantuwarga.netlify.app |
|
Help @ekamuktia to check |
There was a problem hiding this comment.
LGTM 💯
Thanks, Mas @mazipan for working on it.
Mbak @ekamuktia, please help to review these changes as well, thanks! 🙏
| if (bucket.key) { | ||
| if (checkDocSize && bucket.doc_count > 0) { | ||
| return ( | ||
| <option | ||
| key={`option-${key}-${bIdx + 1}`} | ||
| value={bucket.key} | ||
| > | ||
| {bucket.key} | ||
| </option> | ||
| ); | ||
| } | ||
|
|
||
| // FAQ page doesn't check the doc_count | ||
| return ( | ||
| <option | ||
| key={`option-${key}-${bIdx + 1}`} | ||
| value={bucket.key} | ||
| > | ||
| {bucket.key} | ||
| </option> | ||
| ) | ||
| ); | ||
| ); | ||
| } |
There was a problem hiding this comment.
For this part, buckets that have doc_count 0 is still printed even though the checkDocSize is true because it goes to the 2nd return. So now, all the filters are always shown.
If the intention for FAQ page is to always show all the categories, another way to do it is to generate filterItems value from groupped faq instead of using value generated from useSearch.
This way, the filter category order can be in the same order as how the FAQ items are shown which probably is more natural for FAQ page.
There was a problem hiding this comment.
Could you please report another issue for this Mbak @ekamuktia? So we can do a rework later. Thanks! 🙏
There was a problem hiding this comment.
For option no 2, I think it will need more time to be done, since it need to refactor the way we select the selected filter. It can be done on #197 if we want to pick the ticket
Closes #203
Description
Fix bug on FAQ filter that showing a wrong data when we search any keywords
Changes
checkDocSize: booleanon SearchFormfaqpage.Screenshots
Before
After