Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditional on filter #229

Merged
merged 1 commit into from
Jul 20, 2021
Merged

fix: conditional on filter #229

merged 1 commit into from
Jul 20, 2021

Conversation

mazipan
Copy link
Member

@mazipan mazipan commented Jul 20, 2021

Solve a comment on #218

@netlify
Copy link

netlify bot commented Jul 20, 2021

✔️ Deploy Preview for wargabantuwarga ready!

🔨 Explore the source changes: 7f8f13b

🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/60f6e9e11f0ee400075d5fa3

😎 Browse the preview: https://deploy-preview-229--wargabantuwarga.netlify.app

@mazipan mazipan requested a review from ekamuktia July 20, 2021 15:21
@mazipan mazipan mentioned this pull request Jul 20, 2021
2 tasks
Copy link
Collaborator

@ekamuktia ekamuktia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The similar search issue still happens on Province page because of the search rule, but I think we need to discuss the rule first for that issue.

@ekamuktia ekamuktia merged commit 013f372 into kawalcovid19:main Jul 20, 2021
@mazipan mazipan deleted the mazipan/fix-conditional branch July 20, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants