fix: getKebabCase #294

[fzn0x]

Fixes #294 #110

Description

Convert the whitespace and underscore to minus sign without replace the spaces with camel case to fix the issue.

replace(/[\s_]+/g, '-')

Current Tasks

• Fix: getKebabCase

[netlify]

✔️ Deploy Preview for wargabantuwarga ready!

🔨 Explore the source changes: 138c2ff

🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/60fcbb571730c80008c6372e

😎 Browse the preview: https://deploy-preview-313--wargabantuwarga.netlify.app

[fzn0x]

PoC

[ekamuktia]

For the test case mentioned in #294 it's okay

But there are some cases that still not covered, for example:
Text containing special character
"PUTRA SOERADI" Jual Peti Mati: -putra-soeradi-jual-peti-mati
Hoo Hap Hwee (Perkumpulan Budi Abadi): hoo-hap-hwee-perkumpulan-budi-abadi-
Please trim trailing -

Also for text containing ., what is the rule?
Could you confirm the rule and include it on test case? @zainfathoni
For example, with updated function, it'll be:
D.I. Yogyakarta: d.i.-yogyakarta
UD. Bpk. Giyanto Sedia/Jual Peti Jenazah: ud.-bpk.-giyanto-sedia-jual-peti-jenazah
Ambulancesiaga.com: ambulancesiaga.com
Samator, PT. Aneka Gas Industri, Tbk.: samator-pt.-aneka-gas-industri-tbk.
I think the . should be removed, or replaced with -

[zainfathoni]

Please add all the edge cases for into the issue description, Mbak @ekamuktia. We can discuss all the possibilities there.

You should have had access to edit the issue description because I have invited you as a maintainer of this repository. If you aren't able to do it, please check your email to accept the invitation, thanks!

[ekamuktia]

Test cases updated in #294 description

[fzn0x]

Test cases updated in #294 description

just done it with the new test cases, will start commiting ASAP

[ekamuktia]

Please fix parts that causing eslint error by adding new line as suggested on the error message

https://github.com/kawalcovid19/wargabantuwarga.com/pull/313/checks?check_run_id=3140847528

[zainfathoni]

Thanks for working on it @fncolon, but we're not merging until we set up a proper unit & integration tests infrastructure for #178, I'm currently working on it at #358. 🙏

[fzn0x]

Thanks for working on it @fncolon, but we're not merging until we set up a proper unit & integration tests infrastructure for #178, I'm currently working on it at #358. 🙏

Thanks sir Zain, i will keep watching this PR to avoid merge conflicts next time, thanks 🙏

[zainfathoni]

I've merged #358, so please continue with this PR while updating the test cases to match the expected values from the descriptions. Thanks, @fncolon! 🙏

[fzn0x]

I've merged #358, so please continue with this PR while updating the test cases to match the expected values from the descriptions. Thanks, @fncolon! 🙏

Hello sir Zain, the expected value from the issue and the test is different, which one should i follow?

[zainfathoni]

I've merged #358, so please continue with this PR while updating the test cases to match the expected values from the descriptions. Thanks, @fncolon! 🙏

Hello sir Zain, the expected value from the issue and the test is different, which one should i follow?

That expected value was for the old implementation, we need to put those wrong values so that the test doesn't break the main branch build. You should update the test to the actual result of your updated implementation, if the tests are successful, it proves that your regex actually works. 😉

[fzn0x]

I've merged #358, so please continue with this PR while updating the test cases to match the expected values from the descriptions. Thanks, @fncolon! 🙏

Hello sir Zain, the expected value from the issue and the test is different, which one should i follow?

That expected value was for the old implementation, we need to put those wrong values so that the test doesn't break the main branch build. You should update the test to the actual result of your updated implementation, if the tests are successful, it proves that your regex actually works. 😉

already update the unit test based on current implementation

[codecov]

Codecov Report

Merging #313 (138c2ff) into main (703c887) will increase coverage by 0.45%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   13.15%   13.60%   +0.45%     
==========================================
  Files          70       67       -3     
  Lines         859      823      -36     
  Branches      229      228       -1     
==========================================
- Hits          113      112       -1     
+ Misses        742      707      -35     
  Partials        4        4              

Impacted Files	Coverage Δ
lib/string-utils.ts	36.11% <75.00%> (+4.99%)	⬆️
components/__tests__/report-button.test.tsx
components/__tests__/search-form.test.tsx

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703c887...138c2ff. Read the comment docs.

[zainfathoni]

LGTM 💯

Based on the exhaustive test on getKebabCase, now we're pretty confident that the function works as expected. Thanks a lot, @fncolon! 🙏

The requested changes have been implemented.