Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getKebabCase #294 #313

Merged
merged 18 commits into from
Jul 25, 2021
Merged

fix: getKebabCase #294 #313

Changes from 7 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7b4428c
fix: getKebabCase #294
fzn0x Jul 22, 2021
440060d
fix: str can be undefined
fzn0x Jul 22, 2021
9c2febf
Merge branch 'main' into patch-1
fzn0x Jul 22, 2021
f768617
Merge branch 'kawalcovid19:main' into patch-1
fzn0x Jul 23, 2021
f0286d7
fix(string-utils): pass new test cases #294 by @ekamutia
fzn0x Jul 23, 2021
0147b16
update(string-utils): add new `.` rule in kebab-case
fzn0x Jul 23, 2021
0378adb
Merge branch 'main' into patch-1
fzn0x Jul 23, 2021
1bdcdbe
fix: eslint error
fzn0x Jul 23, 2021
7ab61f1
fix: eslint error
fzn0x Jul 23, 2021
dd4bbc6
fix: indent with less spaces
fzn0x Jul 23, 2021
014bf72
Merge branch 'main' into patch-1
zainfathoni Jul 24, 2021
28f63fb
fix: unit test based on current implementation
fzn0x Jul 24, 2021
41ddae9
Test `toSnakeCase` and `toTitleCase`
zainfathoni Jul 25, 2021
9e62404
Merge branch 'main' into patch-1
zainfathoni Jul 25, 2021
fa74467
Merge branch 'main' into patch-1
zainfathoni Jul 25, 2021
b7edb21
Remove unused functions and fix type warnings on string-utils
zainfathoni Jul 25, 2021
8db1ed5
Exclude the test files from the code coverage collections
zainfathoni Jul 25, 2021
138c2ff
Exclude the test files from the code coverage collections
zainfathoni Jul 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/string-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export function replaceSpacesWithCamelCase(str: string): string {
* @returns {string} `str`, without non-alphanumeric characters
*/
export function replaceSpecialCharacterWithSpace(str: string): string {
return str.replace(/[^a-zA-Z0-9. ]/g, " ");
return str.replace(/[^a-zA-Z0-9]/g, " ");
}

/**
Expand All @@ -60,7 +60,7 @@ export function removeSpaces(str: string): string {
* @returns {string} kebab-cased version of `str`
*/
export function convertToKebabCase(str: string): string {
return str.replace(/([a-z])([A-Z])/g, "$1-$2").toLowerCase();
return str.trim().replace(/([a-z])([A-Z])/g, "$1-$2").replace(/[\s_.]+/g, '-').toLowerCase();
}

/**
Expand All @@ -71,9 +71,7 @@ export function convertToKebabCase(str: string): string {
*/
export function getKebabCase(str?: string): string {
return convertToKebabCase(
removeSpaces(
replaceSpecialCharacterWithSpace(replaceSpacesWithCamelCase(str ?? "")),
),
replaceSpecialCharacterWithSpace(str ?? ""),
);
}

Expand Down