Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider issue version on issue filters #739

Open
Tracked by #781
MarceloRobert opened this issue Jan 9, 2025 · 0 comments · May be fixed by #862
Open
Tracked by #781

Consider issue version on issue filters #739

MarceloRobert opened this issue Jan 9, 2025 · 0 comments · May be fixed by #862
Assignees
@Francisco2002

Comments

@MarceloRobert
Copy link
Collaborator

Currently the issue filter on treeDetails or hardwareDetails is only considering the issue_id, which is only part of the primary key. In case there are 2 issues with the same id but different versions, the filter will currently catch both of them when it should catch only the one with the same version as the version of the selected issue for the filter.
@MarceloRobert MarceloRobert mentioned this issue Jan 9, 2025
Merged
@MarceloRobert MarceloRobert self-assigned this Jan 20, 2025
@Francisco2002 Francisco2002 mentioned this issue Jan 20, 2025
Open
27 tasks
@Francisco2002 Francisco2002 moved this from Todo to In Progress in KernelCI Web Dashboard Jan 28, 2025
Francisco2002 added a commit that referenced this issue Jan 30, 2025
@Francisco2002
feat: add types to issue filters
337c455 
- use tuple (issue_id, issue_version) shape to pass issue filters
- create function to format issue name with version

Part of #739
Francisco2002 added a commit that referenced this issue Jan 30, 2025
@Francisco2002
feat: add issue version in filter
8c5c8f7 
- create a function to validate issue id and issue version for a issue
- pass issue versino in functions to validate build/test (tree and
  hardware)
- use formatter function to issue label
- send the issue version in frontend

Close #739
@Francisco2002 Francisco2002 linked a pull request Jan 30, 2025 that will close this issue
Open
@Francisco2002 Francisco2002 moved this from In Progress to In Review in KernelCI Web Dashboard Jan 30, 2025
Francisco2002 added a commit that referenced this issue Jan 31, 2025
@Francisco2002
feat: add types to issue filters
e416d63 
- use tuple (issue_id, issue_version) shape to pass issue filters
- create function to format issue name with version

Part of #739
Francisco2002 added a commit that referenced this issue Jan 31, 2025
@Francisco2002
feat: add issue version in filter
a4688d2 
- create a function to validate issue id and issue version for a issue
- pass issue versino in functions to validate build/test (tree and
  hardware)
- use formatter function to issue label
- send the issue version in frontend

Close #739
Francisco2002 added a commit that referenced this issue Jan 31, 2025
@Francisco2002
feat: add types to issue filters
3e2a20b 
- use tuple (issue_id, issue_version) shape to pass issue filters
- create function to format issue name with version

Part of #739
Francisco2002 added a commit that referenced this issue Jan 31, 2025
@Francisco2002
feat: add issue version in filter
23ad725 
- create a function to validate issue id and issue version for a issue
- pass issue versino in functions to validate build/test (tree and hardware)
- use formatter function to issue label
- send the issue version in frontend

Close #739
Francisco2002 added a commit that referenced this issue Jan 31, 2025
@Francisco2002
feat: add issue version in filter
70754e0 
- create a function to validate issue id and issue version for a issue
- pass issue versino in functions to validate build/test (tree and hardware)
- use formatter function to issue label
- send the issue version in frontend

Close #739
Francisco2002 added a commit that referenced this issue Jan 31, 2025
@Francisco2002
feat: add issue version in filter
9503aca 
- create a function to validate issue id and issue version for a issue
- pass issue versino in functions to validate build/test (tree and hardware)
- use formatter function to issue label
- send the issue version in frontend

Close #739
Francisco2002 added a commit that referenced this issue Jan 31, 2025
@Francisco2002
feat: add types to issue filters
e7cf6c7 
- use tuple (issue_id, issue_version) shape to pass issue filters
- create function to format issue name with version

Part of #739
Francisco2002 added a commit that referenced this issue Jan 31, 2025
@Francisco2002
feat: add issue version in filter
56ec831 
- create a function to validate issue id and issue version for a issue
- pass issue versino in functions to validate build/test (tree and hardware)
- use formatter function to issue label
- send the issue version in frontend

Close #739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Francisco2002 Francisco2002

Labels
None yet
Projects
KernelCI Web Dashboard
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: filter by issue version kernelci/dashboard
2 participants
@Francisco2002 @MarceloRobert