Make passing list type arguments to k4run easier and add tests to verify parsing #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
k4run
forGaudi::Property<vector<T>>
algorithm properties. This is a breaking change, previously the same was possible with adding to the list by passing the argument multiple times with different valuesENDRELEASENOTES
Although this is a breaking change, I think this is an improvement to the current situation because
vector<string>
property that is defaulted to be empty. What makes this special is that e.g. thePodioInput.collections
properties is such a list of strings and currently it would be impossible to change that from the command line.I am not sure how many actual workflows this currently breaks. I think / hope not too many. In the end my major motivation at the moment is actually for testing, where this would be extremely handy to avoid having to write a second options file just to change effectively one list of values.