PodioInput: Read all collections by default, allow to limit them with the collections property
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
improve-podio-input
branch
from
012c455 to
54324c3
Compare
4 tasks
Zehvogel
reviewed
Nov 17, 2023
Comment on lines
+196
to
+213
| const auto& collsToRead = [&]() { | ||
| if (m_collectionNames.empty()) { | ||
| return m_podioDataSvc->getEventFrame().getAvailableCollections(); | ||
| } else { | ||
| return m_collectionNames.value(); | ||
| } | ||
| }(); |
There was a problem hiding this comment.
my c++ knowledge is not as advanced but why do we need this as a lambda? 🥴
There was a problem hiding this comment.
The pattern is called an immediately invoked function expression (IIFE) and it is mainly used for "complicated" initialization logic, where it can help to
- reduce the scope of temporary variables that are necessary for the initialization
- Allows to declare the initialized object as
const, instead of having it mutable and dealing with the logic outside.
So in this case really only to have a const& instead of just a &.
tmadlener
force-pushed
the
improve-podio-input
branch
2 times, most recently
from
0b7e4b9 to
9e4fde6
Compare
tmadlener
force-pushed
the
improve-podio-input
branch
from
9e4fde6 to
f8c7325
Compare
|
Implemented the reading of the collections from the command line via the |
tmadlener
force-pushed
the
improve-podio-input
branch
from
f8c7325 to
da8ba07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
collectionsproperty to allow limiting the collections that are read to a subset of collections.ENDRELEASENOTES
Partially addresses #105