Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(developer): Core crash debugging sil_ipa keyboard #10915

Closed
darcywong00 opened this issue Mar 4, 2024 · 5 comments · Fixed by #10919
Closed

bug(developer): Core crash debugging sil_ipa keyboard #10915

darcywong00 opened this issue Mar 4, 2024 · 5 comments · Fixed by #10919
Assignees
Milestone

Comments

@darcywong00
Copy link
Contributor

darcywong00 commented Mar 4, 2024

I was looking into keymanapp/keyboards#2401 on MSEA time (adding subscript numerals to sil_ipa).

I tried to type n> and the right-shift key (to type >) threw this exception
image
which crashed the entire keyboard project.

In further repros, I found just typing right-shift in the debugger caused the same exception

Details for error report for Keyman app:
Application Identifier: tike-17.0.280-beta
Error Identifier: BE0F3BD5FF484E3C08AE2D901401CE37

Configuration

Windows 11 Version 22H2 (OS build 22621.3155)
Keyman Developer 17.0.280-beta
Keyboard: sil_ipa (from master)

@mcdurdin
Copy link
Member

mcdurdin commented Mar 4, 2024

Shouldn't press the right shift key. Golly gosh.

@mcdurdin mcdurdin added this to the B17S3 milestone Mar 4, 2024
@mcdurdin
Copy link
Member

mcdurdin commented Mar 4, 2024

😁

Copy link

sentry-io bot commented Mar 4, 2024

Sentry Issue: KEYMAN-DEVELOPER-1RE

OS Version: Windows 10.0.22621 (3155)
Report Version: 104


Application Specific Information:
Exception EExternalException in module keymancore-1.dll at 0008864B.
External exception 80000003.


Thread 0
0   keymancore-1.dll                0x61e9864b          common_assert_to_message_box<T> (assert.cpp:388)
1   tike.exe                        0x730040            Upload_Settings.KeymanCom_Protocol_Server (Upload_Settings.pas:143)
2   keymancore-1.dll                0x61e98d10          [inlined] common_assert (assert.cpp:423)
3   keymancore-1.dll                0x61e98d10          _wassert (assert.cpp:443)
4   keymancore-1.dll                0x61e1d812          km_core_state_debug_items (km_core_debug_api.cpp:47)
5   tike.exe                        0xdc7a70            UfrmDebug.TfrmDebug.ProcessKeyEvent (UfrmDebug.pas:468)
6   tike.exe                        0xdc76d0            UfrmDebug.TfrmDebug.HandleMemoKeydown (UfrmDebug.pas:344)
7   tike.exe                        0xdc7730            UfrmDebug.TfrmDebug.memoMessage (UfrmDebug.pas:365)
8   tike.exe                        0xd3bc42            KeymanDeveloperDebuggerMemo.TKeymanDeveloperDebuggerMemo.WndProc (KeymanDeveloperDebuggerMemo.pas:124)
9   tike.exe                        0x579cda            Vcl.Controls.TWinControl.MainWndProc (Vcl.Controls.pas:9977)
10  tike.exe                        0x48bdc5            System.Classes.StdWndProc (System.Classes.pas:17929)
11  USER32.dll                      0x77322e62          _InternalCallWinProc
12  USER32.dll                      0x77313c45          UserCallWinProcCheckWow
13  USER32.dll                      0x77312504          DispatchMessageWorker
14  USER32.dll                      0x7731204f          DispatchMessageW
15  tike.exe                        0x684f4b            Vcl.Forms.TApplication.ProcessMessage (Vcl.Forms.pas:10747)
16  tike.exe                        0x684f8e            Vcl.Forms.TApplication.HandleMessage (Vcl.Forms.pas:10777)
17  tike.exe                        0x6852c1            Vcl.Forms.TApplication.Run (Vcl.Forms.pas:10915)

@mcdurdin
Copy link
Member

mcdurdin commented Mar 4, 2024

Left shift works fine.

Right shift crashes for me too.

@darcywong00
Copy link
Contributor Author

yep, I tried all the modifiers and only right-shift is crashing

mcdurdin added a commit that referenced this issue Mar 4, 2024
Fixes #10915.

Note that a more systemic fix to keyman core will involve ensuring that
the debug list is always properly terminated, but that does not need to
happen in beta.
@mcdurdin mcdurdin linked a pull request Mar 4, 2024 that will close this issue
mcdurdin added a commit that referenced this issue Mar 4, 2024
@mcdurdin mcdurdin closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants