fix(developer): Treat Right Shift as Shift in debugger

[mcdurdin]

Fixes #10915.

Note that a more systemic fix to keyman core will involve ensuring that the debug list is always properly terminated, but that does not need to happen in beta.

User Testing

• TEST_DEBUG_MODIFIERS: In the Keyman Developer integrated debugger, verify that none of the keys on the keyboard cause Keyman Developer to crash as shown in bug(developer): Core crash debugging sil_ipa keyboard #10915.

[keymanapp-test-bot]

User Test Results

Test specification and instructions

• ✅ TEST_DEBUG_MODIFIERS (PASSED): Tested with the attached PR build Keyman Developer Version 17.0.281-beta-test-10919 on Windows 10 OS and here is my observation: 1. Opened a custom-made project in the Keyman Developer. 2. Compiled it. 3. Opened the debugger window. 4. Enter some letters. 5. Pressed Left Shift Key times, then pressing the Right Shift key multiple times doesn't crash the keyboard or show any error message. Seems to be working as expected. (notes)

Test Artifacts

• Developer
  • Keyman Developer
  • Compiler Regression Tests
  • kmcomp.zip
• Keyboards
  • Test Keyboards

[bharanidharanj]

Test Results

• TEST_DEBUG_MODIFIERS (PASSED): Tested with the attached PR build Keyman Developer Version 17.0.281-beta-test-10919 on Windows 10 OS and here is my observation: 1. Opened a custom-made project in the Keyman Developer. 2. Compiled it. 3. Opened the debugger window. 4. Enter some letters. 5. Pressed Left Shift Key times, then pressing the Right Shift key multiple times doesn't crash the keyboard or show any error message. Seems to be working as expected.

  

[darcywong00]

lgtm

[keyman-server]

Changes in this pull request will be available for download in Keyman version 17.0.284-beta