Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): linker warnings for keyman core when building Keyman for Mac #11423

Closed
1 of 8 tasks
sgschantz opened this issue May 13, 2024 · 7 comments · Fixed by #12223
Closed
1 of 8 tasks

chore(core): linker warnings for keyman core when building Keyman for Mac #11423

sgschantz opened this issue May 13, 2024 · 7 comments · Fixed by #12223
Assignees
Labels
chore core/ Keyman Core
Milestone

Comments

@sgschantz
Copy link
Contributor

sgschantz commented May 13, 2024

Describe the bug

Seeing dozens of these linker warnings while building Keyman for Mac:

Object file (/Users/sgschantz/projects/keyman/core/build/mac/debug/libkeymancore.a[x86_64][26](kmx_kmx_actions.cpp.o)) was built for newer 'macOS' version (12.0) than being linked (10.13)

Keyman apps

  • Keyman for Android
  • Keyman for iPhone and iPad
  • Keyman for Linux
  • Keyman for macOS
  • Keyman for Windows
  • Keyman Developer
  • KeymanWeb
  • Other - give details at bottom of form

Keyman version

17.0.322-beta

Operating system

macOS 14.4.1 Sonoma

@sgschantz sgschantz added the bug label May 13, 2024
@keymanapp-test-bot keymanapp-test-bot bot added chore core/ Keyman Core and removed bug labels May 13, 2024
@sgschantz sgschantz changed the title chore(core): linker warnings for keyman core when building K4M chore(core): linker warnings for keyman core when building Keyman for Mac May 13, 2024
@mcdurdin mcdurdin modified the milestones: A18S2, A18S3 May 21, 2024
@mcdurdin mcdurdin modified the milestones: A18S3, A18S4 Jun 7, 2024
@darcywong00 darcywong00 modified the milestones: A18S4, A18S5 Jun 21, 2024
@darcywong00 darcywong00 modified the milestones: A18S5, A18S6 Jul 8, 2024
@darcywong00 darcywong00 modified the milestones: A18S6, A18S7 Jul 19, 2024
@darcywong00 darcywong00 modified the milestones: A18S7, A18S8 Aug 2, 2024
@srl295
Copy link
Member

srl295 commented Aug 6, 2024

@sgschantz are you still seeing this?

@sgschantz
Copy link
Contributor Author

@sgschantz are you still seeing this?

I just built with master and saw no linker warnings. What did you change?

@srl295
Copy link
Member

srl295 commented Aug 6, 2024

@sgschantz are you still seeing this?

I just built with master and saw no linker warnings. What did you change?

I didn't change anything… it does sound like out of date files. Let's close this and reopen if it comes back.

@srl295 srl295 closed this as completed Aug 6, 2024
@sgschantz
Copy link
Contributor Author

Sorry, not sure why I didn't see the warnings locally, but I do see these on ci builds. Check the log here for the latest build of 18.

There are many statements like this:
[18:07:04] : [Step 5/7] ld: warning: object file (/Users/marc_durdin/buildAgent/work/fae170dc1caceadf/keyman/core/build/mac-x86_64/release/subprojects/icu/source/common/libsicuuc.a[2](stubdata.cpp.o)) was built for newer 'macOS' version (14.0) than being linked (10.13)

@sgschantz sgschantz reopened this Aug 14, 2024
@darcywong00 darcywong00 modified the milestones: A18S8, A18S9 Aug 17, 2024
@sgschantz
Copy link
Contributor Author

sgschantz commented Aug 19, 2024

@srl295 -- I just realized that the warnings switched from 12.0 to 14.0. Is there some way to control what version of macOS core is being built for?

Our minimum version is 10.13, and it looks like a similar issue (#9060) may be causing crashes on startup with Big Sur (11) and Catalina (10.15). I don't see any evidence that it is related to this issue, but it is interesting that it is only happening on OS versions less than 12.

@srl295
Copy link
Member

srl295 commented Aug 19, 2024

I found this

$ strings ./core/build/mac-x86_64/release/meson-private/build.dat | fgrep MACOSX_DEPL
'--prefix=/usr/local/opt/[email protected]' '--enable-ipv6' '--datarootdir=/usr/local/opt/[email protected]/share' '--datadir=/usr/local/opt/[email protected]/share' '--without-ensurepip' '--enable-loadable-sqlite-extensions' '--with-openssl=/usr/local/opt/openssl@3' '--enable-optimizations' '--with-system-expat' '--with-system-libmpdec' '--with-readline=editline' '--with-lto' '--enable-framework=/usr/local/opt/[email protected]/Frameworks' '--with-dtrace' '--with-dbmliborder=ndbm' 'MACOSX_DEPLOYMENT_TARGET=14' 'CFLAGS=-isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk' 'CFLAGS_NODIST=-I/usr/local/include' 'LDFLAGS=-isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk' 'LDFLAGS_NODIST=-L/usr/local/lib -Wl,-rpath,/usr/local/lib' 'CPPFLAGS=-I/usr/local/include' 'py_cv_module__tkinter=disabled' 'PKG_CONFIG_PATH=/usr/local/opt/mpdecimal/lib/pkgconfig:/usr/local/opt/openssl@3/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig:/usr/local/opt/sqlite/lib/pkgconfig:/usr/local/opt/xz/lib/pkgconfig' 'PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig:/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/14' 'CC=clang'

(I'm on Sonoma 14.5)

so it shows MACOSX_DEPLOYMENT_TARGET=14

What we might need to do is to set this version in cmake and keep it in sync with xcode…

I also found #11302 where the xcode side was updated.

srl295 added a commit that referenced this issue Aug 19, 2024
- add as option to compiler
- Match version in #11302

Fixes: #11423
@srl295
Copy link
Member

srl295 commented Aug 19, 2024

mcdurdin pushed a commit that referenced this issue Aug 21, 2024
- add as option to compiler
- Match version in #11302

Fixes: #11423
mcdurdin pushed a commit that referenced this issue Aug 22, 2024
- add as option to compiler
- Match version in #11302

Fixes: #11423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore core/ Keyman Core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants