-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core): linker warnings for keyman core when building Keyman for Mac #11423
Comments
@sgschantz are you still seeing this? |
I just built with master and saw no linker warnings. What did you change? |
I didn't change anything… it does sound like out of date files. Let's close this and reopen if it comes back. |
Sorry, not sure why I didn't see the warnings locally, but I do see these on ci builds. Check the log here for the latest build of 18. There are many statements like this: |
@srl295 -- I just realized that the warnings switched from 12.0 to 14.0. Is there some way to control what version of macOS core is being built for? Our minimum version is 10.13, and it looks like a similar issue (#9060) may be causing crashes on startup with Big Sur (11) and Catalina (10.15). I don't see any evidence that it is related to this issue, but it is interesting that it is only happening on OS versions less than 12. |
I found this $ strings ./core/build/mac-x86_64/release/meson-private/build.dat | fgrep MACOSX_DEPL
'--prefix=/usr/local/opt/[email protected]' '--enable-ipv6' '--datarootdir=/usr/local/opt/[email protected]/share' '--datadir=/usr/local/opt/[email protected]/share' '--without-ensurepip' '--enable-loadable-sqlite-extensions' '--with-openssl=/usr/local/opt/openssl@3' '--enable-optimizations' '--with-system-expat' '--with-system-libmpdec' '--with-readline=editline' '--with-lto' '--enable-framework=/usr/local/opt/[email protected]/Frameworks' '--with-dtrace' '--with-dbmliborder=ndbm' 'MACOSX_DEPLOYMENT_TARGET=14' 'CFLAGS=-isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk' 'CFLAGS_NODIST=-I/usr/local/include' 'LDFLAGS=-isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk' 'LDFLAGS_NODIST=-L/usr/local/lib -Wl,-rpath,/usr/local/lib' 'CPPFLAGS=-I/usr/local/include' 'py_cv_module__tkinter=disabled' 'PKG_CONFIG_PATH=/usr/local/opt/mpdecimal/lib/pkgconfig:/usr/local/opt/openssl@3/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig:/usr/local/opt/sqlite/lib/pkgconfig:/usr/local/opt/xz/lib/pkgconfig' 'PKG_CONFIG_LIBDIR=/usr/lib/pkgconfig:/usr/local/Homebrew/Library/Homebrew/os/mac/pkgconfig/14' 'CC=clang' (I'm on Sonoma 14.5) so it shows What we might need to do is to set this version in cmake and keep it in sync with xcode… I also found #11302 where the xcode side was updated. |
OK i was looking at the wrong build log, i see the messages now on https://build.palaso.org/buildConfiguration/KeymanMac_Master/488041?buildTab=log&focusLine=2309&logView=flowAware&expandAll=true |
Describe the bug
Seeing dozens of these linker warnings while building Keyman for Mac:
Object file (/Users/sgschantz/projects/keyman/core/build/mac/debug/libkeymancore.a[x86_64][26](kmx_kmx_actions.cpp.o)) was built for newer 'macOS' version (12.0) than being linked (10.13)
Keyman apps
Keyman version
17.0.322-beta
Operating system
macOS 14.4.1 Sonoma
The text was updated successfully, but these errors were encountered: