Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): set mac build version for meson cli build to 10.13 🍒 🏠 #12246

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix(core): set mac build version for meson cli build to 10.13 🍒 🏠 #12246

merged 1 commit into from
Aug 23, 2024

Conversation

mcdurdin
Copy link
Member

Fixes: #11423
Cherry-pick-of: #12223

@keymanapp-test-bot skip

@mcdurdin mcdurdin requested a review from rc-swag as a code owner August 21, 2024 15:19
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Aug 21, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(core): set mac build version for meson cli build to 10.13 🍒 fix(core): set mac build version for meson cli build to 10.13 🍒 🏠 Aug 21, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S9 milestone Aug 21, 2024
@github-actions github-actions bot added core/ Keyman Core cherry-pick Change already merged into another (stable) branch fix labels Aug 21, 2024
@mcdurdin mcdurdin mentioned this pull request Aug 21, 2024
Merged
darcywong00
darcywong00 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@srl295 @mcdurdin
fix(core): set mac build version for meson cli build to 10.13
e20e231 
- add as option to compiler
- Match version in #11302

Fixes: #11423
@mcdurdin mcdurdin force-pushed the fix/core/cherry-pick/11423-fix-mac-build-version branch from f1ee4ca to e20e231 Compare August 22, 2024 05:53
@mcdurdin mcdurdin merged commit 9bb5a0c into stable-17.0 Aug 23, 2024
18 checks passed
@mcdurdin mcdurdin deleted the fix/core/cherry-pick/11423-fix-mac-build-version branch August 23, 2024 10:33
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcywong00 darcywong00 darcywong00 approved these changes

@rc-swag rc-swag Awaiting requested review from rc-swag rc-swag is a code owner

Assignees
No one assigned
Labels
cherry-pick Change already merged into another (stable) branch core/ Keyman Core fix stable
Projects
Keyman
Archived in project
Milestone
A18S9
Development

Successfully merging this pull request may close these issues.
4 participants
@mcdurdin @keyman-server @darcywong00 @srl295