Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): set mac build version for meson cli build to 10.13 #12223

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Aug 19, 2024

- add as option to compiler
- Match version in #11302

Fixes: #11423
@srl295 srl295 self-assigned this Aug 19, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S9 milestone Aug 19, 2024
@github-actions github-actions bot added core/ Keyman Core fix labels Aug 19, 2024
@srl295 srl295 requested a review from sgschantz August 19, 2024 15:22
@srl295
Copy link
Member Author

srl295 commented Aug 19, 2024

@sgschantz This doesn't seem to have an effect locally, but let's see if it works in ci.

@srl295
Copy link
Member Author

srl295 commented Aug 19, 2024

@sgschantz seems promising

@srl295
Copy link
Member Author

srl295 commented Aug 19, 2024

OK as far as I can tell this seems to remove the warning.

Copy link
Contributor

@sgschantz sgschantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolute perfection

@sgschantz
Copy link
Contributor

I guess we probably need to cherry-pick to 17 stable also.

@srl295 srl295 merged commit 49eb3bf into master Aug 20, 2024
21 checks passed
@srl295 srl295 deleted the fix/core/11423-fix-mac-build-version branch August 20, 2024 14:03
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.93-alpha

@mcdurdin
Copy link
Member

Cherry-picked to #12246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core/ Keyman Core fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

chore(core): linker warnings for keyman core when building Keyman for Mac
4 participants