-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epic: windows-updates 💽 #10041
Draft
mcdurdin
wants to merge
93
commits into
master
Choose a base branch
from
epic/windows-updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
epic: windows-updates 💽 #10041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User tests have not yet been defined for the PR
label
Nov 22, 2023
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined Test Artifacts |
Starts to refactor the online update check in Windows so that the results are stored to disk and can be checked at any time. This commit: * removes keepintouch frame * adds update frame * adds serialization of update check data * presents the serialized update check data in the update frame Online updates won't currently work.
Co-authored-by: Eberhard Beilharz <[email protected]>
…pdate-ui feat(windows): Online Update check stream update data 💽
…/windows-updates chore: merge master into epic/windows-updates 💽
Just using the TUpdateCheckResponse gives us enough detail for now as we no longer have a UI set which packages to install
…ows-updates chore: merge master into windows-updates
mcdurdin
changed the title
chore: establish epic/windows-updates 💽
epic/windows-updates 💽
Dec 11, 2023
background update state machine doesn't even build
Co-authored-by: Marc Durdin <[email protected]>
Remove the extra time since last update check and let remote update check control it. Also remove the events on the buttons as and use the button modal property
Use FStateInstance array instead of invidual StateClass flags
…ows-updates chore: merge master into windows-updates 💽
There was some dead code from before the RemoteUpdateCheck refactor was created. This is removed in this commit
Co-authored-by: Marc Durdin <[email protected]>
…/add-apply-now-update # Keyman Conventional Commit suggestions: # # - Link to a Sentry issue with git trailer: # Fixes: _MODULE_-_ID_ # - Give credit to co-authors: # Co-authored-by: _Name_ <_email_> # - Use imperative, present tense ('attach' not 'attaches', 'attached' etc) # - Don't include a period at the end of the title # - Always include a blank line before trailers # - More: https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes
…ows-updates chore: merge master into windows-updates 💽
…pdate feat(windows): add state machine to control installation including apply now update 💽
…ows-updates chore: merge master into windows-updates 💽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
common/
epic-windows-updates
oem/fv/windows/
oem/fv/
oem/
user-test-missing
User tests have not yet been defined for the PR
windows/config/
windows/engine/
windows/
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #10038
Related PRs