-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mac): mnemonic layout support 🐘 #11334
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
feat(mac): include km_types and u16 feat(mac): include filesystem and some kmx feat(mac): include old functions in keymap feat(mac): include kmx_file, mc_kmxfile feat(mac): include deadkey, filesystem, km_types, import_rules,mc_kmxfile feat(mac): include functions in mcompile.cpp/h feat(mac): #includes out to be used
This reverts commit d32e352. # Conflicts: # mac/mcompile/keymap.cpp # mac/mcompile/keymap.h # mac/mcompile/mcompile.cpp # mac/mcompile/mcompile.h
feat(mac): open more functions feat(mac): open DoConvert-InitializeUCHR feat(mac): open write_US_ToVector feat(mac): (temporarily) add mac_ to function names to be able to distinguish between linux-functions and mac functions if needed feat(mac): finished mac_createOneVectorFromBothKeyboards() feat(mac): started DoConvert feat(mac): mcompile tidy up
feat(mac): mcompile tidy up
feat(mac): mcompile new X_find_Shiftstates to verify shiftstates feat(mac): mcompile fill rgkey for base, shift, opt, shift+opt including CAPS feat(mac): mcompile fill rgkey prevent writing x01 into rgkey[] feat(mac): mcompile tidy up code
7b98ea5
to
5139ba4
Compare
…meson-utils.inc.sh
…ild and do_test to meson-utils.inc.sh
…github.com/keymanapp/keyman into chore/mac/mcompile_mac-CommonMesonPatterns
…github.com/keymanapp/keyman into chore/mac/mcompile_mac-CommonMesonPatterns
…nMesonPatterns chore(common): consolidate common meson patterns and use 'c++17' in standard.meson.build 🐘
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's get this in and finish off this epic. I know we'll still need to do more work to integrate into the core products but at least this will be ready to go
keys[0].dpOutput = new KMX_WCHAR[4]; | ||
keys[0].dpOutput[0] = UC_SENTINEL; | ||
keys[0].dpOutput[1] = CODE_DEADKEY; | ||
keys[0].dpOutput[2] = deadkey; // TODO: translate to unique index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this TODO resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a comment from mcompile-windows - I did not do any changes
fixes #7068
see #3345
see #9384
This is a proposal to rewrite mcompile for macOS.
It will be a standalone implementation for macOS for now which is similar to the standalone implementation for Linux. (#9384)
To achieve this we can reuse most of the code from mcompile-Linux, especially the structure and the .kmx rewriting. We need to adapt the keyboard interrogation though. On Linux we use x11; For macOS we use the Carbon.h library.
Since we keep the structure of the code as it is on Linux, we only have to change the content of several functions, especially those that handle the keyboard interrogation and the mapping between Keycodes/Scancodes and Keyvalues.
Therefore for mcompile-mac we will first set up the the .kmx rewriting, then add the handling of non-deadkeys and in the last step add the handling of deadkeys.
Maybe in a next step we may combine the 3 versions of mcompile for Windows, Linux, macOS into a cross-platform version of mcompile.
@keymanapp-test-bot skip