fix(core): look for emcc instead of emcc.py
#12235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermshiperete
requested review from
mcdurdin,
jahorton and
rc-swag
as code owners
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
github-actions
bot
added
common/
common/resources/
|
Don't forget kmcmplib's references to emcc.py as well |
|
See also #8934 which did the opposite change. |
`emcc.py` is not marked as executable in emcripten's git repo so the build failed when trying to locate emscripten. However, it turns out that `emcc` is marked as executable, so we use that instead. On Windows however, we still need to use `emcc.py` because otherwise Meson won't detect it as valid compiler.
ermshiperete
force-pushed
the
fix/core/emcc_detect
branch
from
88657c0 to
ab3722e
Compare
mcdurdin
approved these changes
Aug 20, 2024
|
Changes in this pull request will be available for download in Keyman version 18.0.94-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emcc.pyis not marked as executable in emcripten's git repo so the build failed when trying to locate emscripten. However, it turns out thatemccis marked as executable, so we use that instead on macOS and Linux (on Windows, executable bit is irrelevant).@keymanapp-test-bot skip