chore(common): add offline support for emscripten #12740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to build with emscripten if offline (when passing the `--offline` parameter). Previously this failed because as part of locating emscripten we try to pull the latest repo version and install the desired emscripten version. With this change when `--offline` is specified we try to use the currently installed version of emsdk. If it isn't installed or if the wrong version is installed we will fail the build.
ermshiperete
requested review from
mcdurdin,
jahorton and
srl295
as code owners
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
approved these changes
Nov 28, 2024
|
Changes in this pull request will be available for download in Keyman version 18.0.148-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to build with emscripten if offline (when passing the
--offlineparameter). Previously this failed because as part of locating emscripten we try to pull the latest repo version and install the desired emscripten version. With this change when--offlineis specified we try to use the currently installed version of emsdk. If it isn't installed or if the wrong version is installed we will fail the build.@keymanapp-test-bot skip