-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(common/web): remove .c8rc.json from types and merge exclusions into package.json #12813
chore(common/web): remove .c8rc.json from types and merge exclusions into package.json #12813
Conversation
…into package.json
User Test ResultsTest specification and instructions User tests are not required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there is a comment in common/web/types/build.sh
that references .c8rc.json
that should be removed now.
…remove-c8rc-json-and-merge-exclusions-into-package-json
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now really LGTM 😄
…remove-c8rc-json-and-merge-exclusions-into-package-json
Changes in this pull request will be available for download in Keyman version 18.0.160-alpha |
Running
./build.sh test
oncommon/web/types
currently includes test files as well as source. Removing.c8rc.json
and merging the exclusions from there intopackage.json
fixes this.(Fix suggested by @mcdurdin)
@keymanapp-test-bot skip