Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common/web): remove .c8rc.json from types and merge exclusions into package.json #12813

Conversation

markcsinclair
Copy link
Contributor

@markcsinclair markcsinclair commented Dec 9, 2024

Running ./build.sh test on common/web/types currently includes test files as well as source. Removing .c8rc.json and merging the exclusions from there into package.json fixes this.

(Fix suggested by @mcdurdin)

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 9, 2024

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S17 milestone Dec 9, 2024
@markcsinclair markcsinclair marked this pull request as draft December 9, 2024 14:50
@markcsinclair markcsinclair self-assigned this Dec 9, 2024
@markcsinclair markcsinclair added web/ and removed web/ labels Dec 9, 2024
@markcsinclair markcsinclair marked this pull request as ready for review December 9, 2024 14:53
Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is a comment in common/web/types/build.sh that references .c8rc.json that should be removed now.

@github-actions github-actions bot added web/ and removed web/ labels Dec 10, 2024
@markcsinclair
Copy link
Contributor Author

LGTM, but there is a comment in common/web/types/build.sh that references .c8rc.json that should be removed now.

Done

Copy link
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now really LGTM 😄

…remove-c8rc-json-and-merge-exclusions-into-package-json
@github-actions github-actions bot added web/ and removed web/ labels Dec 16, 2024
@markcsinclair markcsinclair merged commit 09f0614 into master Dec 16, 2024
3 checks passed
@markcsinclair markcsinclair deleted the chore/common/web/types/remove-c8rc-json-and-merge-exclusions-into-package-json branch December 16, 2024 11:43
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.160-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants