Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common/web): remove .c8rc.json from types and merge exclusions into package.json #12813

Merged
merged 4 commits into from
Dec 16, 2024
Merged

chore(common/web): remove .c8rc.json from types and merge exclusions into package.json #12813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69cd317
chore(common/web): remove .c8rc.json from types and merge exclusions …
markcsinclair Dec 9, 2024
c2a7d53
chore(common/web): Merge branch 'master' into chore/common/web/types/…
markcsinclair Dec 10, 2024
3289b31
chore(common/web): updated comment in build.sh to note excludes are i…
markcsinclair Dec 10, 2024
c9da863
chore(common/web): Merge branch 'master' into chore/common/web/types/…
markcsinclair Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions common/web/types/.c8rc.json
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion common/web/types/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function do_test() {

readonly C8_THRESHOLD=60

# Excludes are defined in .c8rc.json
# Excludes are defined in package.json
c8 -skip-full --reporter=lcov --reporter=text --lines $C8_THRESHOLD --statements $C8_THRESHOLD --branches $C8_THRESHOLD --functions $C8_THRESHOLD mocha ${MOCHA_FLAGS} "${builder_extra_params[@]}"
builder_echo warning "Coverage thresholds are currently $C8_THRESHOLD%, which is lower than ideal."
builder_echo warning "Please increase threshold in build.sh as test coverage improves."
Expand Down
8 changes: 7 additions & 1 deletion common/web/types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,13 @@
"src/keyman-touch-layout/keyman-touch-layout-file-writer.ts",
"src/osk/osk.ts",
"src/schemas/*",
"tests/"
"tests/",
"src/keyboard-object.ts",
"src/outputTarget.interface.ts",
"src/*.d.ts",
"src/main.ts",
"src/schema-validators.ts",
"src/schemas.ts"
]
},
"sideEffects": false
Expand Down
Loading