-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default axes for N-dimensional fft APIs #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you be more explicit in the PR title? ND
is not very clear. "N-D" or "N-dimensional" is easier to understand.
Thank you for your review. I have fixed accordingly. May I have your second review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me, thanks for this feature
Sure, I will merge this. Thank you for your help |
In this PR, we set default axes for ND fft APIs.
For example, for 2D Views, default
axes = {-2, -1}
.