Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default axes for N-dimensional fft APIs #141

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

In this PR, we set default axes for ND fft APIs.
For example, for 2D Views, default axes = {-2, -1}.

using axes_type = KokkosFFT::axis_type<2>;
axes_type axes  = {-2, -1};
KokkosFFT::fftn(execution_space(), x, out);
KokkosFFT::fftn(execution_space(), x, out, axes);

@yasahi-hpc yasahi-hpc self-assigned this Sep 24, 2024
@yasahi-hpc yasahi-hpc added enhancement New feature or request cleanup labels Sep 24, 2024
@yasahi-hpc yasahi-hpc marked this pull request as draft September 24, 2024 17:51
@yasahi-hpc yasahi-hpc marked this pull request as ready for review September 25, 2024 06:50
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you be more explicit in the PR title? ND is not very clear. "N-D" or "N-dimensional" is easier to understand.

common/unit_test/Test_Utils.cpp Outdated Show resolved Hide resolved
fft/unit_test/Test_Transform.cpp Outdated Show resolved Hide resolved
@yasahi-hpc yasahi-hpc changed the title Set default axes for ND fft APIs Set default axes for N-dimensional fft APIs Sep 25, 2024
common/src/KokkosFFT_utils.hpp Outdated Show resolved Hide resolved
common/src/KokkosFFT_utils.hpp Outdated Show resolved Hide resolved
@yasahi-hpc
Copy link
Collaborator Author

Can you be more explicit in the PR title? ND is not very clear. "N-D" or "N-dimensional" is easier to understand.

Thank you for your review. I have fixed accordingly. May I have your second review?

Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, thanks for this feature

@yasahi-hpc
Copy link
Collaborator Author

Sure, I will merge this. Thank you for your help

@yasahi-hpc yasahi-hpc merged commit eaf9e85 into kokkos:main Sep 26, 2024
20 checks passed
@yasahi-hpc yasahi-hpc deleted the default-axes-for-fftn branch September 26, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants