Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(KONFLUX-2742): upload test results to quay as OCI artifacts #992

Merged
merged 6 commits into from
Jun 21, 2024
Merged

feat(KONFLUX-2742): upload test results to quay as OCI artifacts #992

merged 6 commits into from
Jun 21, 2024

Conversation

ralphbean
Copy link
Member

@ralphbean ralphbean commented May 4, 2024 •
edited
Loading

For https://issues.redhat.com/browse/KONFLUX-2742

Will post example output

@ralphbean ralphbean mentioned this pull request May 4, 2024
Closed
@ralphbean ralphbean force-pushed the upload-oci branch 3 times, most recently from 8cb4e2c to bd000ff Compare May 5, 2024 00:49
@ralphbean ralphbean mentioned this pull request May 5, 2024
Merged
@ralphbean ralphbean marked this pull request as draft May 5, 2024 01:05
@ralphbean
Copy link
Member Author

/retest

1 similar comment
@ralphbean
Copy link
Member Author

/retest

@ralphbean ralphbean changed the title Upload test results to quay as OCI artifacts feat(KONFLUX-2742): upload test results to quay as OCI artifacts May 5, 2024
@ralphbean
Copy link
Member Author

I see a similarity in this and #913. We should consider:

  • Should the result name convention be aligned with Trusted Artifacts with OCI storage #913? i.e., should the results here be named SARIF_ARTIFACT and CLAMAV_ARTIFACT?
  • Should the image used to push the artifact into quay be aligned?

@ralphbean ralphbean requested review from zregvart and lcarva May 5, 2024 14:43
@zregvart
Copy link
Member

zregvart commented May 6, 2024

Was there a consideration of using in-toto vulnerabilities predicate?

@ralphbean
Copy link
Member Author

@zregvart no, it wasn't considered at all - not until you raised it just now.

@ralphbean
Copy link
Member Author

/retest

@ralphbean
Copy link
Member Author

/retest

1 similar comment
@ralphbean
Copy link
Member Author

/retest

@ralphbean
Copy link
Member Author

For the moment, this is blocked on https://issues.redhat.com/browse/KONFLUX-2838

@ralphbean
Copy link
Member Author

/retest

@ralphbean ralphbean force-pushed the upload-oci branch 2 times, most recently from 90c6f48 to 576445b Compare May 16, 2024 10:59
@ralphbean ralphbean marked this pull request as ready for review May 16, 2024 11:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ralphbean
Copy link
Member Author

/retest

@ralphbean ralphbean force-pushed the upload-oci branch 5 times, most recently from 6b620e3 to 71a1ce6 Compare June 18, 2024 14:03
@ralphbean ralphbean enabled auto-merge June 21, 2024 12:29
@ralphbean ralphbean requested review from mmorhun and chmeliik June 21, 2024 12:31
dirgim
dirgim approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ralphbean ralphbean added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit 4c8dfd6 Jun 21, 2024
7 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Jun 21, 2024
Closed
@ralphbean ralphbean deleted the upload-oci branch June 21, 2024 16:00
@kdudka kdudka mentioned this pull request Jul 22, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashvardhannanavati yashvardhannanavati yashvardhannanavati left review comments

@gbenhaim gbenhaim gbenhaim left review comments

@dirgim dirgim dirgim approved these changes

@jsztuka jsztuka Awaiting requested review from jsztuka

@hugares hugares Awaiting requested review from hugares

@14rcole 14rcole Awaiting requested review from 14rcole

@zregvart zregvart Awaiting requested review from zregvart

@lcarva lcarva Awaiting requested review from lcarva

@mmorhun mmorhun Awaiting requested review from mmorhun

@chmeliik chmeliik Awaiting requested review from chmeliik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ralphbean @zregvart @gbenhaim @yashvardhannanavati @dirgim