-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update supported python versions #79
Conversation
modified: tnefparse/mapi.py modified: tnefparse/util.py
Also, add `flake8` env to tox env list modified: tnefparse/mapi.py modified: tnefparse/util.py modified: tox.ini
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 92.14% 92.90% +0.75%
==========================================
Files 7 7
Lines 1311 1296 -15
Branches 121 117 -4
==========================================
- Hits 1208 1204 -4
+ Misses 78 70 -8
+ Partials 25 22 -3
Continue to review full report at Codecov.
|
modified: .travis.yml modified: README.rst modified: setup.py modified: tox.ini
This fixes #80 modified: .github/workflows/pythonpackage.yml modified: .travis.yml modified: HISTORY.rst modified: setup.py modified: tox.ini
This cli tool removes Python 2 specific code, and modernizes the used Python syntax. modified: scripts/make_props.py modified: tests/test_cmdline.py modified: tests/test_decoding.py modified: tnefparse/codepage.py modified: tnefparse/mapi.py modified: tnefparse/tnef.py
... by applying `pyupgrade --py36-plus` on code base. I put this in a separate commit, just in case f-strings are not wanted, so the changes are easier to revert. modified: tnefparse/tnef.py
I do not get the logic of CodeCov - the overall coverage was raised, due to removing Py2 compatibility code, but it still fails ... I see no problem with this PR. |
Seems to me it complains because the tests do not cover enough (92.14%) of the "new code that's added" (despite overall improved coverage). But I'm fine being a bit more relaxed in this case. |
Drop Python 2 compatibility code
Drop support for Python 3.5
Add support for Python 3.9
Apply
pyupgrade
on code base to modernize syntaxfixes #75
fixes #80