Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update supported python versions #79

Merged
merged 7 commits into from
Nov 24, 2020
Merged

update supported python versions #79

merged 7 commits into from
Nov 24, 2020

Conversation

jugmac00
Copy link
Collaborator

@jugmac00 jugmac00 commented Nov 22, 2020

Drop Python 2 compatibility code
Drop support for Python 3.5
Add support for Python 3.9
Apply pyupgrade on code base to modernize syntax

fixes #75
fixes #80

modified:   tnefparse/mapi.py
modified:   tnefparse/util.py
Also, add `flake8` env to tox env list

modified:   tnefparse/mapi.py
modified:   tnefparse/util.py
modified:   tox.ini
@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #79 (be05052) into master (d2ccc68) will increase coverage by 0.75%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   92.14%   92.90%   +0.75%     
==========================================
  Files           7        7              
  Lines        1311     1296      -15     
  Branches      121      117       -4     
==========================================
- Hits         1208     1204       -4     
+ Misses         78       70       -8     
+ Partials       25       22       -3     
Impacted Files Coverage Δ
tnefparse/tnef.py 92.06% <85.71%> (ø)
tnefparse/codepage.py 80.00% <100.00%> (ø)
tnefparse/mapi.py 80.00% <100.00%> (+0.83%) ⬆️
tnefparse/util.py 66.66% <100.00%> (+6.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ccc68...be05052. Read the comment docs.

modified:   .travis.yml
modified:   README.rst
modified:   setup.py
modified:   tox.ini
This fixes #80

modified:   .github/workflows/pythonpackage.yml
modified:   .travis.yml
modified:   HISTORY.rst
modified:   setup.py
modified:   tox.ini
This cli tool removes Python 2 specific code, and modernizes the used
Python syntax.

modified:   scripts/make_props.py
modified:   tests/test_cmdline.py
modified:   tests/test_decoding.py
modified:   tnefparse/codepage.py
modified:   tnefparse/mapi.py
modified:   tnefparse/tnef.py
... by applying `pyupgrade --py36-plus` on code base.

I put this in a separate commit, just in case f-strings are not wanted,
so the changes are easier to revert.

modified:   tnefparse/tnef.py
@jugmac00 jugmac00 marked this pull request as ready for review November 22, 2020 21:48
@jugmac00
Copy link
Collaborator Author

I do not get the logic of CodeCov - the overall coverage was raised, due to removing Py2 compatibility code, but it still fails ...

I see no problem with this PR.

@jugmac00 jugmac00 changed the title [WIP] update supported python versions update supported python versions Nov 23, 2020
@petri
Copy link
Member

petri commented Nov 23, 2020

I do not get the logic of CodeCov - the overall coverage was raised, due to removing Py2 compatibility code, but it still fails ...

I see no problem with this PR.

Seems to me it complains because the tests do not cover enough (92.14%) of the "new code that's added" (despite overall improved coverage). But I'm fine being a bit more relaxed in this case.

@petri petri merged commit a9668ef into master Nov 24, 2020
@jugmac00 jugmac00 mentioned this pull request Nov 26, 2020
@jrideout jrideout deleted the update-python-versions branch January 22, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.9 Drop support for Python 2.7 (and 3.5)
2 participants