Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-ovn-cni: fix pinger result when timeout is reached #3457

Merged
merged 1 commit into from
Nov 24, 2023

kube-ovn-cni: fix pinger result when timeout is reached

7aa7fe9
Select commit
Loading
Failed to load commit list.
Merged

kube-ovn-cni: fix pinger result when timeout is reached #3457

kube-ovn-cni: fix pinger result when timeout is reached
7aa7fe9
Select commit
Loading
Failed to load commit list.
Deleted GitHub App / Copilot for PRs succeeded Nov 24, 2023 in 16s

Analysis complete

Summary

Improve network readiness check by handling gateway ping failure. Add error return and warning log in pingGateway function in pkg/daemon/ovs.go.

Walkthrough

  • Add a check for gateway packet loss in pingGateway function (link) to improve error handling and logging of network readiness

Poem

pingGateway checks
packets from the gateway - none?
logs a warning, fails

Emoji

⚠️❌🔧

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 12 seconds
pkg/daemon/ovs.go ✅ Finished 5 seconds