Add default subnet in custom vpc to the beginning of the list #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
Pull Request Test Coverage Report for Build 12355542560Details
💛 - Coveralls |
oilbeater
reviewed
Dec 20, 2024
| @@ -151,7 +151,9 @@ func (c *Controller) handleAddNamespace(key string) error { | |||
| return err | |||
| } | |||
| if s.Name == vpc.Spec.DefaultSubnet { | |||
| lss = []string{s.Name} | |||
| if slices.Contains(vpc.Spec.Namespaces, key) && key != metav1.NamespaceSystem { | |||
There was a problem hiding this comment.
Why exclude kube-system here?
There was a problem hiding this comment.
while you can add kube-system to the custom VPCs, I would not add the default subnet from custom VPC to any pod that is going to be created in kube-system namespace, wdyt @oilbeater?
There was a problem hiding this comment.
That's right, it's dangerous.
oilbeater
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)