Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default subnet in custom vpc to the beginning of the list #4826

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Add default subnet in custom vpc to the beginning of the list #4826

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c08bb08
Add default subnet in custom vpc to the beginning of the list
cnvergence Dec 12, 2024
0ef9c1d
Merge branch 'master' into fix-default-subnet-vpc
cnvergence Dec 12, 2024
6c48c2c
Merge branch 'master' into fix-default-subnet-vpc
cnvergence Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/controller/namespace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ func (c *Controller) handleAddNamespace(key string) error {
return err
}
if s.Name == vpc.Spec.DefaultSubnet {
lss = []string{s.Name}
if slices.Contains(vpc.Spec.Namespaces, key) && key != metav1.NamespaceSystem {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exclude kube-system here?

Copy link
Contributor Author

@cnvergence cnvergence Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you can add kube-system to the custom VPCs, I would not add the default subnet from custom VPC to any pod that is going to be created in kube-system namespace, wdyt @oilbeater?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, it's dangerous.

lss = append([]string{s.Name}, lss...)
}
}
}
}
Expand Down
Loading