Setup golang linting for gwctl and fix existing lint errors #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
gauravkghildiyal
force-pushed
the
gwctl-golint
branch
from
dcbd41b to
926764c
Compare
|
/retest |
|
Thanks @gauravkghildiyal! /lgtm |
k8s-ci-robot
added
the
lgtm
gauravkghildiyal
force-pushed
the
gwctl-golint
branch
from
926764c to
12b3379
Compare
k8s-ci-robot
removed
the
lgtm
gauravkghildiyal
force-pushed
the
gwctl-golint
branch
2 times, most recently
from
c4afb30 to
7186e41
Compare
|
/assign @youngnick |
gauravkghildiyal
force-pushed
the
gwctl-golint
branch
2 times, most recently
from
0af620b to
f97973a
Compare
|
Will add another LGTM once this is rebased. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
gauravkghildiyal
force-pushed
the
gwctl-golint
branch
from
f97973a to
09297a1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Enabling linting for gwctl directory
Which issue(s) this PR fixes:
Fixes #2918
Does this PR introduce a user-facing change?: