Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gock doesn't work with https #18

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

MatousJobanek
Copy link
Contributor

gock doesn't work with https, so instead of mocking, we were talking to the actual clusters.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.33%. Comparing base (650c3ec) to head (0c36d5d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   65.35%   65.33%   -0.02%     
==========================================
  Files          38       38              
  Lines        1980     1979       -1     
==========================================
- Hits         1294     1293       -1     
  Misses        528      528              
  Partials      158      158              
Flag Coverage Δ
unittests 65.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xcoulon
Copy link
Contributor

xcoulon commented Mar 21, 2024

gock doesn't work with https, so instead of mocking, we were talking to the actual clusters.

perfect timing for this PR! I was just wondering why I suddenly got this error ;)

@xcoulon xcoulon merged commit 6d9fe43 into kubesaw:master Mar 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants