Propagation of container details #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthyx
previously approved these changes
Mar 6, 2025
|
Summary:
|
… include non-Kubernetes use case Signed-off-by: Ben <[email protected]>
slashben
force-pushed
the
fix/propagation-of-container-details
branch
from
8730335 to
80d62f9
Compare
matthyx
approved these changes
Mar 6, 2025
|
Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request to
pkg/rulemanager/v1/rule_manager.goincludes changes to improve the enrichment of rule failures with Kubernetes and container details. The most important changes include the introduction of a new method to handle this enrichment and the refactoring of existing code to use this new method.Improvements to rule failure enrichment:
enrichRuleFailureWithContainerDetailsto encapsulate the logic for enriching rule failures with Kubernetes and container details.enrichRuleFailuremethod to utilize the newenrichRuleFailureWithContainerDetailsmethod for adding Kubernetes and container details to rule failures.