Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagation of container details #499

Closed
wants to merge 1 commit into from
Closed

Propagation of container details #499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 52 additions & 36 deletions pkg/rulemanager/v1/rule_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,56 @@ func (rm *RuleManager) processEvent(eventType utils.EventType, event utils.K8sEv
rm.metrics.ReportRuleProcessed(rule.Name())
}
}

func (rm *RuleManager) enrichRuleFailureWithContainerDetails(ruleFailure ruleengine.RuleFailure) {
isKubernetesWorkload := ruleFailure.GetTriggerEvent().K8s.PodName != "" && ruleFailure.GetTriggerEvent().K8s.Namespace != ""
// Enrich RuntimeAlertK8sDetails
runtimek8sdetails := ruleFailure.GetRuntimeAlertK8sDetails()
if runtimek8sdetails.Image == "" {
runtimek8sdetails.Image = ruleFailure.GetTriggerEvent().Runtime.ContainerImageName
}

if runtimek8sdetails.ImageDigest == "" {
runtimek8sdetails.ImageDigest = ruleFailure.GetTriggerEvent().Runtime.ContainerImageDigest
}

if runtimek8sdetails.Namespace == "" {
runtimek8sdetails.Namespace = ruleFailure.GetTriggerEvent().K8s.Namespace
}

if runtimek8sdetails.PodName == "" {
if isKubernetesWorkload {
runtimek8sdetails.PodName = ruleFailure.GetTriggerEvent().K8s.PodName
} else {
// TODO: This is a temporary solution to get the pod name for non-kubernetes workloads.
runtimek8sdetails.PodName = string(ruleFailure.GetTriggerEvent().Runtime.RuntimeName)
}
}

if runtimek8sdetails.PodNamespace == "" {
runtimek8sdetails.PodNamespace = ruleFailure.GetTriggerEvent().K8s.Namespace
}

if runtimek8sdetails.ContainerName == "" {
if isKubernetesWorkload {
runtimek8sdetails.ContainerName = ruleFailure.GetTriggerEvent().K8s.ContainerName
} else {
runtimek8sdetails.ContainerName = ruleFailure.GetTriggerEvent().Runtime.ContainerName
}
}

if runtimek8sdetails.ContainerID == "" {
runtimek8sdetails.ContainerID = ruleFailure.GetTriggerEvent().Runtime.ContainerID
}

if runtimek8sdetails.HostNetwork == nil {
hostNetwork := ruleFailure.GetTriggerEvent().K8s.HostNetwork
runtimek8sdetails.HostNetwork = &hostNetwork
}

ruleFailure.SetRuntimeAlertK8sDetails(runtimek8sdetails)
}

func (rm *RuleManager) enrichRuleFailure(ruleFailure ruleengine.RuleFailure) ruleengine.RuleFailure {
var err error
var path string
Expand Down Expand Up @@ -332,42 +382,8 @@ func (rm *RuleManager) enrichRuleFailure(ruleFailure ruleengine.RuleFailure) rul

ruleFailure.SetRuntimeProcessDetails(runtimeProcessDetails)

// Enrich RuntimeAlertK8sDetails
runtimek8sdetails := ruleFailure.GetRuntimeAlertK8sDetails()
if runtimek8sdetails.Image == "" {
runtimek8sdetails.Image = ruleFailure.GetTriggerEvent().Runtime.ContainerImageName
}

if runtimek8sdetails.ImageDigest == "" {
runtimek8sdetails.ImageDigest = ruleFailure.GetTriggerEvent().Runtime.ContainerImageDigest
}

if runtimek8sdetails.Namespace == "" {
runtimek8sdetails.Namespace = ruleFailure.GetTriggerEvent().K8s.Namespace
}

if runtimek8sdetails.PodName == "" {
runtimek8sdetails.PodName = ruleFailure.GetTriggerEvent().K8s.PodName
}

if runtimek8sdetails.PodNamespace == "" {
runtimek8sdetails.PodNamespace = ruleFailure.GetTriggerEvent().K8s.Namespace
}

if runtimek8sdetails.ContainerName == "" {
runtimek8sdetails.ContainerName = ruleFailure.GetTriggerEvent().K8s.ContainerName
}

if runtimek8sdetails.ContainerID == "" {
runtimek8sdetails.ContainerID = ruleFailure.GetTriggerEvent().Runtime.ContainerID
}

if runtimek8sdetails.HostNetwork == nil {
hostNetwork := ruleFailure.GetTriggerEvent().K8s.HostNetwork
runtimek8sdetails.HostNetwork = &hostNetwork
}

ruleFailure.SetRuntimeAlertK8sDetails(runtimek8sdetails)
// Adding K8s and container details to the rule failure
rm.enrichRuleFailureWithContainerDetails(ruleFailure)

if cloudServices := rm.dnsManager.ResolveContainerProcessToCloudServices(ruleFailure.GetTriggerEvent().Runtime.ContainerID, runtimeProcessDetails.ProcessTree.PID); cloudServices != nil {
ruleFailure.SetCloudServices(cloudServices.ToSlice())
Expand Down
Loading