A bug with the environment's coloring persists. #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the bug where the color bar appeared when selecting a coloring per element again.
|
I also noticed this problem, but have no clear idea how to fix it |
Merged
|
The issue was that we did not remove the GLModel from 3Dmol renderer when switching off the environments highlighting. It was not caught previously because both models had the same color anyway. This and the color bar re-appearing should be fixed by #322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a environment is enabled and further disabled, changing the color property while keeping the environments disabled indeed updates the color for every atom, although a ghost of the previous environment's coloring remains on top of the current coloring. If the environment is then re-enabled and further re-disabled by the user, the "ghost" will disappear. But, changing the color property again will result in the same problem.
I tried to fix this issue today but I can't understand where the problem comes from. I need help @Luthaf
Although, I found another bug wwhere the color bar appeared when selecting a coloring per element again and fixed it!