Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atoms color fixes #322

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Atoms color fixes #322

merged 5 commits into from
Dec 15, 2023

Conversation

Luthaf
Copy link
Contributor

@Luthaf Luthaf commented Dec 11, 2023

Fix #319 and some related code and layout cleanup.

@MaximeScope could you give this a look and check that everything works as intended?

@ceriottm
Copy link
Contributor

ceriottm commented Dec 11, 2023

Ghost environments are fixed, had some issue with the color scale remaining even after switching to element coloring, but might have been down to non-updated widgets. when switching environments on and off and then on, it doesn't switch to environment highlighting until an atom is clicked on, IDK if that is intended or a bug

@ceriottm ceriottm self-requested a review December 11, 2023 23:14
@Luthaf
Copy link
Contributor Author

Luthaf commented Dec 12, 2023

had some issue with the color scale remaining even after switching to element coloring, but might have been down to non-updated widgets

If you manage to reproduce let me know I'll try to fix it.

@Luthaf
Copy link
Contributor Author

Luthaf commented Dec 13, 2023

when switching environments on and off and then on, it doesn't switch to environment highlighting until an atom is clicked on, IDK if that is intended or a bug

Should be fixed now, we just go back to the previously selected center

@ceriottm
Copy link
Contributor

when switching environments on and off and then on, it doesn't switch to environment highlighting until an atom is clicked on, IDK if that is intended or a bug

Should be fixed now, we just go back to the previously selected center

Works.

@ceriottm
Copy link
Contributor

fixed legend layout. @Luthaf only thing I can't seem to manage to fix is the position of the modal, that at least on chrome seem to ignore completely what goes into positionsettingsrectangle

@ceriottm
Copy link
Contributor

Fixed also the alignment I think

@Luthaf
Copy link
Contributor Author

Luthaf commented Dec 15, 2023

I cleaned up the commits, this is good to go for me!

@Luthaf Luthaf merged commit a1fbc8f into main Dec 15, 2023
9 checks passed
@Luthaf Luthaf deleted the atoms-color-fixes branch December 15, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants