Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote/authenticator: drop obsolete ticket authenticator #1216

Conversation

Bastian-Krause
Copy link
Member

Description
Now that #1079 and #1136 are merged, the coordinator no longer supports ticket authentication. Drop the corresponding authenticator class and other ticket auth remains.

Exporters and clients might still talk to older coordinator versions, so leave ticket authentication for these components enabled.

Checklist

  • PR has been tested

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (80595d5) 62.9% compared to head (94400cc) 63.0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1216   +/-   ##
======================================
  Coverage    62.9%   63.0%           
======================================
  Files         159     158    -1     
  Lines       11742   11725   -17     
======================================
  Hits         7391    7391           
+ Misses       4351    4334   -17     
Impacted Files Coverage Δ
labgrid/remote/coordinator.py 80.3% <ø> (+0.2%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jluebbe
Copy link
Member

jluebbe commented Jun 22, 2023

This needs documentation on what to do if the coordinator fails to startup due to an outdated config.

@Bastian-Krause
Copy link
Member Author

Actually, this does not change anything from the user perspective: An up to date coordinator with an outdated config tries to import the now non-existent class labgrid.remote.authenticator.AuthenticatorSession, but fails early because the pexpect, pyserial and xmodem modules are not found. Only if these were installed into the crossbar venv, the user would actually see..

ModuleNotFoundError: No module named 'labgrid.remote.authenticator'

Nonetheless, this is a good opportunity to add a hint in the breaking changes section of v23.1.

Now that labgrid-project#1079 and labgrid-project#1136 are merged, the coordinator no longer supports
ticket authentication. Drop the corresponding authenticator class, do
not advertise ticket auth anymore.

Exporters and clients might still talk to older coordinator versions, so
leave ticket authentication for these components enabled.

Signed-off-by: Bastian Krause <[email protected]>
@Bastian-Krause Bastian-Krause force-pushed the bst/coordinator-drop-ticket-auth branch from 9f79014 to 94400cc Compare June 22, 2023 13:37
@Bastian-Krause
Copy link
Member Author

Added a note on breaking changes as explained above.

@Bastian-Krause Bastian-Krause requested a review from jluebbe July 5, 2023 12:34
@Bastian-Krause Bastian-Krause added this to the v23.1 milestone Jul 20, 2023
@Emantor Emantor merged commit 7d22e76 into labgrid-project:master Sep 6, 2023
@Bastian-Krause Bastian-Krause deleted the bst/coordinator-drop-ticket-auth branch September 6, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants