Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote/authenticator: drop obsolete ticket authenticator #1216

Merged
merged 2 commits into from
Sep 6, 2023
Merged

remote/authenticator: drop obsolete ticket authenticator #1216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84f6dc8
remote/authenticator: drop obsolete ticket authenticator
Bastian-Krause Jun 22, 2023
94400cc
CHANGES: document dropped ticket authentication in v23.1
Bastian-Krause Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ Bug fixes in 23.1

Breaking changes in 23.1
~~~~~~~~~~~~~~~~~~~~~~~~~
- Support for the legacy ticket authentication was dropped: If the coordinator
logs ModuleNotFoundError on startup, switch the crossbar config to anonymous
authentication (see ``.crossbar/config-anonymous.yaml`` for an example).
- The Debian package (``debian/``) no longer contains crossbar. Use the
`coordinator container <https://hub.docker.com/r/labgrid/coordinator>`_ or
install it into a separate local venv as desribed in the
Expand Down
20 changes: 0 additions & 20 deletions labgrid/remote/authenticator.py
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions labgrid/remote/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,11 @@ async def onConnect(self):
enable_tcp_nodelay(self)
self.join(
self.config.realm,
authmethods=["anonymous", "ticket"],
authmethods=["anonymous"],
authid="coordinator",
authextra={"authid": "coordinator"},
)

def onChallenge(self, challenge):
return "dummy-ticket"

@locked
async def onJoin(self, details):
await self.subscribe(self.on_session_join, 'wamp.session.on_join')
Expand Down
3 changes: 0 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,6 @@ testpaths = [
]
addopts = "-p no:labgrid"

[tool.pylint.MASTER]
ignore-paths = ["labgrid/remote/authenticator.py"]

[tool.pylint.imports]
ignored-modules = ["gi"]

Expand Down