fix: disable edit button based on endpoint status #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.48% (-0% 🔻) |
337/6151 |
| 🔴 | Branches | 5.07% (+0% 🔼) |
214/4219 |
| 🔴 | Functions | 3.12% (-0% 🔻) |
63/2022 |
| 🔴 | Lines | 5.38% (-0% 🔻) |
323/6007 |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from 612b54c
lizable
force-pushed
the
fix/disable-edit-based-status
branch
from
7485d56
to
dbe9101
Compare
ironAiken2
force-pushed
the
fix/disable-edit-based-status
branch
from
dbe9101
to
f3c55d5
Compare
Merge activity
|
### TL;DR An update that prevents modifications to an endpoint in `destroyed` and `destroying` state. ### What changed? - Updated status checks to include both 'destroying' and 'destroyed' states - Disabled certain buttons and actions when an endpoint is in 'destroying' or 'destroyed' state [Additionally] - Changed "LLM Playground" tooltip to "LLM Chat Test" in EndpointDetailPage ### How to test? 1. Navigate to the Endpoint List and Detail pages 2. Verify that buttons are properly disabled for endpoints in 'destroying' or 'destroyed' states 3. Check that the tooltip for the LLM chat test button now reads "LLM Chat Test" 4. Attempt to perform actions on endpoints in various states to ensure correct behavior ### Why make this change? This change improves the user experience by: 1. Providing more accurate UI feedback for endpoint statuses 2. Preventing actions on endpoints that are no longer active 3. Ensuring consistency in how endpoint statuses are handled across the application 4. Clarifying the purpose of the LLM chat test button with an updated tooltip --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
lizable
force-pushed
the
fix/disable-edit-based-status
branch
from
f3c55d5
to
612b54c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
An update that prevents modifications to an endpoint in
destroyedanddestroyingstate.What changed?
[Additionally]
How to test?
Why make this change?
This change improves the user experience by:
Checklist: (if applicable)