Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prefix for datafield selection #63

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

tfr42
Copy link
Member

@tfr42 tfr42 commented Oct 25, 2023

Support for DATENFELDKUERZEL: ('S'|'P'|'G'|'F'|'Z') added.

@tfr42 tfr42 added the enhancement New feature or request label Oct 25, 2023
@tfr42 tfr42 self-assigned this Oct 25, 2023
Copy link

@dstenger dstenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import should be corrected. Rest of the code looks fine.

@@ -6,7 +6,7 @@
import java.util.logging.Logger;

import static java.util.Objects.isNull;
import static org.sep3tools.JavaConnector.getBodenQuant;
import static org.sep3tools.JavaConnector.*;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* import should be prevented.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we need some code conventions and a tool which enforces those. Currently ... neither nor.

@tfr42 tfr42 merged commit 5ad7f34 into main Oct 25, 2023
1 check passed
@tfr42 tfr42 deleted the feature/prefixForDatenfeldSelection branch October 25, 2023 13:41
@tfr42 tfr42 added this to the 0.1.0 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants