Extended bracket and color handling #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoltz
reviewed
Apr 9, 2024
| @@ -233,6 +248,11 @@ private static String getColorString(String color) { | |||
| int partialBodenLength = 2; | |||
| while (partialBodenLength <= forColorSeparation.length()) { | |||
| String partialTermForColor = forColorSeparation.substring(forColorSeparation.length() - partialBodenLength); | |||
| if (partialTermForColor.endsWith("=")) { | |||
| bodenTerm = "lich" + bodenTerm; | |||
There was a problem hiding this comment.
@wanhoff Ist die Reihenfolge ("lich" + bodenTerm) korrekt?
There was a problem hiding this comment.
ja, der String wird von hinten beginnend ausgewertet. In Zeile 258 werden die normalen Übersetzungen genauso gebildet.
lgoltz
reviewed
Apr 9, 2024
| @@ -82,7 +82,7 @@ public void verifyFremdDatenfeldExamples() { | |||
| public void verifySepExamples(String df, String propFile) { | |||
| JavaConnector.setPropertiesFile(DBPROPFILENAME); | |||
| JavaConnector.setDf(df); | |||
| Properties properties = loadPropertiesFromFile(propFile, "="); | |||
| Properties properties = loadPropertiesFromFile(propFile, " = "); | |||
There was a problem hiding this comment.
@wanhoff Was ist der Hintergrund für diese Änderung?
There was a problem hiding this comment.
Hintergrund ist, dass '=' nun in den auszuwertenden Zeichenketten vorkommen kann. Es wird bei Farben als 'lich' übersetzt. Daher kann es nicht mehr als einzelnes Zeichen in .properties-Dateien verwendet werden (Ein Doppelpunkt kann auch in den Zeichenketten vorkommen). Daher trenne ich für die Tests nun mit einem in Leerzeichen eingerahmten '='.
lgoltz
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grammar extended for improved bracket and color handling.