Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup PR precheck #114

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Fixup PR precheck #114

merged 3 commits into from
Sep 12, 2023

Conversation

cticenhour
Copy link
Collaborator

This should allow the PR precheck to pass, allowing for full PR testing.

Refs #86

Where part of features, transition to mooseError and mooseWarning where applicable. Where commented out, remove if simple diagnostics and testing and fixup where prior features exist or where well-noted developer diagnostic pathways exist.

Refs lcpp-org#86
@dcurreli dcurreli merged commit fe2a55a into lcpp-org:devel Sep 12, 2023
@dcurreli
Copy link
Contributor

Great, thanks Casey

@cticenhour
Copy link
Collaborator Author

@dcurreli I was hoping you wouldn't merge this immediately....I wanted to test the precheck.

@cticenhour
Copy link
Collaborator Author

cticenhour commented Sep 12, 2023

It appeared as though the PR webhook wasn't working, and I was investigating that.

@dcurreli
Copy link
Contributor

Sorry 😂

@cticenhour
Copy link
Collaborator Author

I think I found the issue - after I get it fixed on the CIVET side, I will make a new PR with a minor change to test everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants