refactor: add List.finRange and Array.finRange #1055
+140
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgdorais
force-pushed
the
finrange
branch
2 times, most recently
from
ca0078b
to
5c2a552
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 19, 2024
|
Mathlib CI status (docs):
|
Harmonize with Mathlib, renaming Fin.list to List.finRange and Fin.enum to Array.finRange.
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 19, 2024
|
This is a second attempt at #899. The Mathlib breakages are too much for now. On hiatus. |
|
Perhaps it would be easier to change the definition in Mathlib first? I appreciate that this situation is super annoying. We could also just rename Mathlib's definition to (I am quite keen to have |
|
Help is more than welcome! Looks like you've already done quite a lot. I'm just catching up... Thanks! |
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 25, 2024
François Dorais has been [working](leanprover-community/batteries#1055) on upstreaming `List.finRange`, but wants to change the definition at the same time. That was running into difficulties, which hopefully are resolved here.
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 25, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 25, 2024
|
@fgdorais, the Mathlib PR changing the definition of Would you like to try again here? I'm very keen to have this in. |
|
In progress... Should build Mathlib on the next run... Ready! |
fgdorais
added
awaiting-review
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harmonize with Mathlib, renaming Fin.list to List.finRange and Fin.enum to Array.finRange.