Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adaptation to batteries#1055 #19487

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fgdorais
Copy link
Collaborator


Once batteries#1055 is merged:

  • Edit lakefile to point to batteries/main
  • Run lake update batteries
  • Commit and merge

Open in Gitpod

@fgdorais fgdorais added the blocked-by-batt-PR This PR depends on a PR to Batteries label Nov 25, 2024
@fgdorais fgdorais changed the title Batteries pr testing 1055 chore: adaptation to batteries#1055 Nov 25, 2024
Copy link

PR summary 864eca313b

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.Fin.VecNotation 336 333 -3 (-0.89%)
Mathlib.Data.List.FinRange 348 349 +1 (+0.29%)
Mathlib.ModelTheory.Encoding 785 786 +1 (+0.13%)
Import changes for all files
Files Import difference
There are 3660 files with changed transitive imports taking up over 158800 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

- finRange
- finRange_succ
- finRange_zero
- getElem_finRange
- length_finRange

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-batt-PR This PR depends on a PR to Batteries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants